Remove validate scorer smoketest#708
Merged
Merged
Conversation
Contributor
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Contributor
|
CodeAnt AI finished reviewing your PR. |
james-rl
approved these changes
Feb 4, 2026
alb-rl
force-pushed
the
alb/remove-validate-scorer-test
branch
from
February 4, 2026 18:16
fc00e7c to
d3f52da
Compare
|
| Metric | Coverage | Required | Status |
|---|---|---|---|
| Functions | 97.48% | 100% | ❌ |
| Lines | 86.49% | - | ℹ️ |
| Branches | 65.75% | - | ℹ️ |
| Statements | 85.19% | - | ℹ️ |
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests)
View detailed coverage report
| File | Functions | Lines | Branches |
|---|---|---|---|
| src/sdk.ts | ❌ 96.15% | 81.41% | 70.83% |
| src/sdk/agent.ts | ✅ 100% | 100% | 100% |
| src/sdk/blueprint.ts | ✅ 100% | 100% | 80% |
| src/sdk/devbox.ts | ✅ 100% | 91.81% | 96.96% |
| src/sdk/execution-result.ts | ✅ 100% | 92.68% | 70.83% |
| src/sdk/execution.ts | ✅ 100% | 94.11% | 83.33% |
| src/sdk/gateway-config.ts | ✅ 100% | 100% | 100% |
| src/sdk/network-policy.ts | ✅ 100% | 100% | 100% |
| src/sdk/scenario-run.ts | ❌ 92.85% | 75% | 50% |
| src/sdk/scenario.ts | ❌ 85.71% | 91.66% | 100% |
| src/sdk/scorer.ts | ❌ 87.5% | 93.33% | 100% |
| src/sdk/snapshot.ts | ✅ 100% | 100% | 100% |
| src/sdk/storage-object.ts | ✅ 100% | 80% | 48.93% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Remove unused smoketest
CodeAnt-AI Description
Remove scorer validation step from object-oriented smoketest
What Changed
Impact
✅ Shorter smoketest runtime✅ Fewer external validation calls during tests✅ Fewer intermittent smoketest failures💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.